fix: changing email to verified not working on admin > users #35299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: b8dcbce The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35299 +/- ##
========================================
Coverage 59.72% 59.72%
========================================
Files 2830 2830
Lines 68363 68363
Branches 15161 15161
========================================
Hits 40829 40829
Misses 24918 24918
Partials 2616 2616
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
juliajforesti
force-pushed
the
fix/email-verified
branch
from
bdb0634 to
14934f4
Compare
sampaiodiego
requested changes
Feb 26, 2025
Member
sampaiodiego
left a comment
sampaiodiego
left a comment
There was a problem hiding this comment.
a test would be awesome 😬
juliajforesti
force-pushed
the
fix/email-verified
branch
3 times, most recently
from
77a0d97 to
bff76cd
Compare
juliajforesti
force-pushed
the
fix/email-verified
branch
from
bff76cd to
d65fa03
Compare
Contributor
|
sampaiodiego
approved these changes
Mar 19, 2025
sampaiodiego
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The email verification on admin/users wasn't working due to a condition added on
saveUserthat was preventingverifiedto be updated.Issue(s)
Steps to test or reproduce
admin/usersMark email as verifiedUser should have the email verified.
Further comments